Amend shapeshifter to allow use of dynamic import #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst implementing the standard import syntax (
import foo from "./bar"
) is problematic due to the statically analyzed nature of these imports, the dynamic import syntax works fine in this context. Unfortunately the shift parser does not support dynamic import and actually throws an error when it sees the keyword, so I have implemented a mildly hacky solution which swaps it out before parsing, then swaps it back in again afterwards.You can see it working by running this code in the REPL: