Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace mocha with vitest #175

Merged
merged 23 commits into from Aug 12, 2022
Merged

replace mocha with vitest #175

merged 23 commits into from Aug 12, 2022

Conversation

felixroos
Copy link
Collaborator

@felixroos
Copy link
Collaborator Author

fixes #145

@felixroos
Copy link
Collaborator Author

waiting for vitest@0.21.1 https://www.npmjs.com/package/vitest

@felixroos
Copy link
Collaborator Author

i have now refactored all tests to vitest + now using the snapshot feature instead of the custom solution. unfortunately, it's actually slower than mocha by ~50% so I am a bit disappointed.. it seems vitest has had a performance drop lately, so hopefully this will get better soon

@felixroos felixroos marked this pull request as ready for review August 12, 2022 21:08
@felixroos
Copy link
Collaborator Author

i think it's still better, because the dev mode seems much quicker + the snapshot feature alone will be of great use. also, if we decide to move to typescript later, this will automatically work. I'll merge this

@felixroos felixroos merged commit 4fb57d2 into main Aug 12, 2022
@felixroos felixroos deleted the vitest branch August 12, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant