Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy hap show, include part in snapshots #291

Merged
merged 2 commits into from Dec 10, 2022
Merged

Fancy hap show, include part in snapshots #291

merged 2 commits into from Dec 10, 2022

Conversation

yaxu
Copy link
Member

@yaxu yaxu commented Dec 9, 2022

Parts are visualised like:
where whole = part: 0/1 → 1/1
where they don't: 2/3 ⇜ (3/4 → 1/1) ⇝ 4/3
where the onset is still intact but offset isn't: (2/3 → 3/4) ⇝ 4/3
vice-versa: 2/3 ⇜ (5/4 → 4/3)

The whole thing looks like:

[ 2/3 ⇜ (1/1 → 5/4) ⇝ 4/3 | note:64.01075614638685 cutoff:688.232561769837 resonance:12 gain:0.5 decay:0.16 sustain:0.5 delay:0.2 room:0.5 pan:0.6 s:piano clip:1 ]

@yaxu yaxu requested a review from felixroos December 9, 2022 13:07
Copy link
Collaborator

@felixroos felixroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the new whole / part format!

@yaxu yaxu merged commit 98e9780 into main Dec 10, 2022
@yaxu yaxu deleted the fancy-hap-show branch December 10, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants