Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated csoundm to use the register facility . #303

Merged
merged 1 commit into from Dec 13, 2022
Merged

Updated csoundm to use the register facility . #303

merged 1 commit into from Dec 13, 2022

Conversation

gogins
Copy link
Contributor

@gogins gogins commented Dec 13, 2022

I'm trying this pull request again. If you don't want this just say so.

The logic you had for using an external instance of Csound was not suited to my use cases, and would have failed in use. The external Csound will, usually, already have compiled an external orchestra and be running, so the csound.mjs module should not call compile or start on an external instance of Csound.

I updated the csoundm function to use the new 'register' function for Patterns. I also updated csoundm to convey the Strudel signals in the same way as the existing csound function.

@felixroos
Copy link
Collaborator

I'll merge this now, though it might make more sense to find a less specific abstraction in the future, making this one obsolete, as outlined in #283 (comment) . also, a solution for key value mappings is still missing, as described here #270 (comment) , an alternative implementation might use channels with unique names.

@felixroos felixroos merged commit 2cd77b0 into tidalcycles:main Dec 13, 2022
@gogins
Copy link
Contributor Author

gogins commented Dec 14, 2022 via email

@gogins
Copy link
Contributor Author

gogins commented Dec 14, 2022 via email

@yaxu yaxu mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants