Add tidal-drum-patterns to examples #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey! thanks for looking into this. could you add these to a separate file? tunes.mjs is used for the shuffle function in the repl. having this large number of drum patterns in there will make it really unlikely that the shuffle will pick a tune that is not a drum pattern.. |
|
yes sure, should be fixed now. And I felt a bit bad to put all these patterns in your file, which really has some beautiful tunes :) |
This reverts commit 0070953.
|
should I just merge this and then add them to a dedicated page in a separate PR? |
|
that sounds great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here this is a first draft to merge the tidal-drum-patterns to the main folder of the examples in the docs.