Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cps in scheduler #493

Merged
merged 6 commits into from Mar 1, 2023
Merged

implement cps in scheduler #493

merged 6 commits into from Mar 1, 2023

Conversation

felixroos
Copy link
Collaborator

partly fixes #470

  • refactored the scheduler to use cps
  • cps is now passed to hap onTrigger
  • added setcps / setCps methods

still missing:

  • patternable cps: how should this work? should the tempo have an effect on the cps pattern too?
  • ui controls: basic version already implemented, but now commented out because it's not clear how the tempo is shared, as it is not part of the code

I'd say having the basic cps functionality working is already a good first step, the missing things can be addressed in a future PR

@yaxu
Copy link
Member

yaxu commented Feb 28, 2023

oh great !!

  • patternable cps: how should this work? should the tempo have an effect on the cps pattern too?

In tidal it's just another control, so you could do e.g. s("bd sd").cps("<0.75 1.5>") or separately cps(saw.range(1,2).slow(4).segment(32)).

This gets a bit complicated for the scheduler. If it's running at 20Hz, it queries the pattern for the right slice, but has to deal with changes in cps during that slice which means the slice is then either too big or too small..

In tidal setcps is just an alias for once . cps

I'd say having the basic cps functionality working is already a good first step, the missing things can be addressed in a future PR

agreed!

@felixroos felixroos merged commit 3cfb0f4 into main Mar 1, 2023
@felixroos felixroos deleted the cps branch March 1, 2023 08:27
This was referenced Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global clock tempo
2 participants