Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music metadata #580

Merged
merged 10 commits into from Jun 9, 2023
Merged

Music metadata #580

merged 10 commits into from Jun 9, 2023

Conversation

roipoussiere
Copy link
Contributor

As explained in #578, this adds support for music metadata.

  • add function to look for music metadata by looking for tags in code comments;
  • update some tunes to add those metadata;
  • display title from music metadata in user patterns;
  • display title from music metadata in examples page;
  • add metadata section in the docs.

@felixroos
Copy link
Collaborator

great, thanks so much!

website/src/pages/learn/code.mdx Outdated Show resolved Hide resolved
website/src/pages/learn/metadata.mdx Outdated Show resolved Hide resolved
website/src/pages/learn/metadata.mdx Outdated Show resolved Hide resolved
@roipoussiere
Copy link
Contributor Author

Thanks for the review.

Updates:

  • parser now supports multiple values and one-liners (see doc);
  • added tests;
  • fixed and improved documentation.

@roipoussiere
Copy link
Contributor Author

I find the syntax // @title Awesome song @by Sam a bit too verbose and disturbing, so I added an alternative syntax using quotes: // "Awesome song" @by Sam.

@roipoussiere
Copy link
Contributor Author

Ready to merge for me. :)

@felixroos felixroos merged commit a3baf07 into tidalcycles:main Jun 9, 2023
1 check passed
@roipoussiere roipoussiere deleted the music_metadata branch June 9, 2023 16:54
@roipoussiere roipoussiere mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants