Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: enable line wrapping #581

Merged
merged 3 commits into from Jun 15, 2023
Merged

Conversation

roipoussiere
Copy link
Contributor

Useful when the editor has a small width (required for #574).

@felixroos
Copy link
Collaborator

maybe also add a setting for that?

@roipoussiere
Copy link
Contributor Author

Yes I can, but I just wonder what is the use case of don't wanting line breaks?

I like to understand user needs before adding many options, which can overload the UI at some point.

@felixroos
Copy link
Collaborator

felixroos commented Jun 8, 2023

Yes I can, but I just wonder what is the use case of don't wanting line breaks?

  • You could have a single line of code with a large amount of data, e.g. voicings. a line wrap would then probably fill the entire screen with data and you need to scroll to the actual pattern
  • You could actually want to scroll horizontally for layouting purposes, example: https://strudel.tidalcycles.org/?_usVdv9dq4rH

@roipoussiere
Copy link
Contributor Author

Ok thanks for the explications, I'm adding the option to the settings.

@roipoussiere
Copy link
Contributor Author

roipoussiere commented Jun 9, 2023

Before to make a PR for this, I'm waiting for #588 to be merged to avoid conflicts, as modifications takes in same places.

@felixroos
Copy link
Collaborator

Just fixed the conflict

@roipoussiere
Copy link
Contributor Author

added the checkbox in last commit

@roipoussiere
Copy link
Contributor Author

It works pretty well with different screen sizes:

image

@felixroos
Copy link
Collaborator

nice! so i suppose it's ready to merge?

@roipoussiere
Copy link
Contributor Author

yep!

@felixroos felixroos merged commit 0862827 into tidalcycles:main Jun 15, 2023
1 check passed
@roipoussiere roipoussiere deleted the line_wrap branch June 15, 2023 10:58
@felixroos felixroos mentioned this pull request Dec 12, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants