Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: add option to display line numbers #582

Merged
merged 1 commit into from Jun 7, 2023

Conversation

roipoussiere
Copy link
Contributor

fix #575

I had to remove this in website/src/styles/index.css:

.cm-gutters {
  display: none !important;
}

There was a particular reason to hide cm gutters in css?

@felixroos
Copy link
Collaborator

felixroos commented Jun 7, 2023

I think I initially hid them because they were a bit mich for the mini repl and also a bit bulky in the main repl.
It might be best if the gutters can be toggled in the settings. I can also do that if you want

@felixroos
Copy link
Collaborator

ah ok sorry I should have read the code before commenting.. now I see it is actually togglable, great!

@felixroos
Copy link
Collaborator

is this ready to merge?

@roipoussiere
Copy link
Contributor Author

yep!

@felixroos felixroos merged commit 90647a8 into tidalcycles:main Jun 7, 2023
1 check passed
@roipoussiere roipoussiere deleted the line_numbers branch June 7, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to display line numbers
2 participants