Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tauri desktop app #613

Merged
merged 7 commits into from Jun 26, 2023
Merged

tauri desktop app #613

merged 7 commits into from Jun 26, 2023

Conversation

vasilymilovidov
Copy link
Contributor

After installing the dependancies, use 'pnpm tauri dev' to run or 'pnpm tauri build' to build.

I'm not that familiar with Strudel's codebase and have never built an app with Tauri before. This is just an attempt at following the official guide for Tauri integration. Everything seems to be working, except webmidi.

I tested it on macOS Ventura. There's some slight audio crackle from time to time, but I have the same issue in Safari.

@felixroos
Copy link
Collaborator

felixroos commented Jun 23, 2023

amazing! and just ~18MB in size :) just tested it and it works!
would you mind adding a README.md to the src-tauri project, with a little guide on how to dev / build?
should also make sense to mention that you need to install rust, e.g. using https://rustup.rs/

I think webaudio is not so optimized on safari / webkit so it should make sense to put more effort into performance on webkit for macos and (some?) linux users (of course not in this PR). theoretically, having a desktop app would also allow packaging a much faster audio engine.....

@vasilymilovidov
Copy link
Contributor Author

vasilymilovidov commented Jun 23, 2023

I was actually able to push it down to 15MB with some rust build optimizations. Will push them and a README soon.

I was also thinking about tinkering with github actions so it would build bundles and installers automatically for a bunch of platforms. What do you think?

@felixroos
Copy link
Collaborator

I was also thinking about tinkering with github actions so it would build bundles and installers automatically for a bunch of platforms. What do you think?

sounds good! probably best to build it on release.. found this on a brief research : https://github.com/softprops/action-gh-release

@vasilymilovidov
Copy link
Contributor Author

sounds good! probably best to build it on release.. found this on a brief research : https://github.com/softprops/action-gh-release

I'll take a look.
I'm also writing a midi sequencer in rust at the moment. I'll see if I can apply this knowledge to Strudel and make midi work from tauri 🙃

@vasilymilovidov
Copy link
Contributor Author

Added a separate workflow for tauri to not mess with existing ones. I think it should work.

@felixroos
Copy link
Collaborator

great! so it will run automatically when a new version tag is pushed?

@vasilymilovidov
Copy link
Contributor Author

yep. tested it only on a dummy repo though. I think I'll make a private clone of strudel repo to test it properly.

@vasilymilovidov
Copy link
Contributor Author

tested it properly and made some adjustments. it builds for mac and windows, but there are issues with ubuntu.

@vasilymilovidov
Copy link
Contributor Author

everything should work now

@felixroos
Copy link
Collaborator

so is it ready to merge then?

@vasilymilovidov
Copy link
Contributor Author

so is it ready to merge then?

yes. I'll work on MIDI support next, but on a new branch.

@felixroos felixroos merged commit 83c1b58 into tidalcycles:main Jun 26, 2023
1 check passed
@felixroos felixroos changed the title tauri test tauri desktop app Jun 29, 2023
@felixroos felixroos mentioned this pull request Jun 29, 2023
@roipoussiere
Copy link
Contributor

roipoussiere commented Jul 1, 2023

Very nice to see this desktop app!

I just want to mention that the .deb probably needs some description:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants