Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More work on highlight IDs #636

Merged
merged 11 commits into from
Jul 4, 2023
Merged

More work on highlight IDs #636

merged 11 commits into from
Jul 4, 2023

Commits on Jul 3, 2023

  1. Pass mininotation locations into highlight state

    @mindofmatthew
    mindofmatthew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    aded178 View commit details
    Browse the repository at this point in the history

  2. Remove highlights when code stops

    @mindofmatthew
    mindofmatthew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ba9562f View commit details
    Browse the repository at this point in the history

  3. Split up highlighting logic and add progress flash

    @mindofmatthew
    mindofmatthew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f5b092a View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. remove mock positions

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7877088 View commit details
    Browse the repository at this point in the history

  2. fix: do not recreate haps mapping on update

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3fc5bb3 View commit details
    Browse the repository at this point in the history

  3. comment out opacity logic for now

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    dacd9af View commit details
    Browse the repository at this point in the history

  4. snapshot tests: sort haps by part

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    00bd60a View commit details
    Browse the repository at this point in the history

  5. Merge pull request tidalcycles#637 from tidalcycles/snapshots-sort-ha… 

    …ps-by-part

snapshot tests: sort haps by part
    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    23e949d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into highlight-ids

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    9e1b9f7 View commit details
    Browse the repository at this point in the history

  7. fix: format

    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7f12ce9 View commit details
    Browse the repository at this point in the history

  8. refactor: 

    - dedupe flash / highlighting logic
- codemirror logic now lives only in codemirror package
- remove old highlighting logic
- use codemirror package in react package
- cleanup CodeMirror6.jsx
- pull setMiniLocations into useHighlighting
- migrate MiniRepl, nano-repl + Repl to new highlighting
    @felixroos
    felixroos committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    34176ab View commit details
    Browse the repository at this point in the history