[Bug Fix] Midi: Don't treat note 0 as false #657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug caused note 0 to be ignored.
I suspect there might be similar issues in other places in the app.
For instance: if you do
"0".note().sound("triangle").pianoroll()
it will display nothing in the piano roll and play a c2 and
"36".note().sound("triangle").pianoroll()
will display in the piano roll and play a c2 as well