New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding filter envelopes and filter order selection #692
Conversation
great, filter envelopes were really missing so far. Maybe go the full way and just add adsr to the filter? The naming system could be similar to how it works with
there could also be Order being a number kind of suggests it supports arbitrary numbers, which might be confusing, not sure what a good alternative is. Maybe default to 24dB entirely? or add separate controls like |
This is now working with the described API. Order is also taking |
this is starting to look good still unsure about the naming:
|
Your suggestions are now implemented. Examples are covering all new keywords (mostly duplicate of lowpass examples changing filter type). Tests have been re-generated, etc.. |
- defaulting to .5 for now...
This commit is proposing the addition of linear or exponential filter envelopes:
lpf(5000).to(500).over(0.2)
It also makes it possible to select the filter order (12db/Oct or 24db/Oct):
lpf(5000).order("<12 24>")
The definitive API and parameter names are not fixed but this is working and it sounds great 馃槃