Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct OSC Support in Tauri #694

Merged
merged 9 commits into from Sep 4, 2023
Merged

Conversation

daslyfe
Copy link
Collaborator

@daslyfe daslyfe commented Sep 4, 2023

Negates the need to run a separate websocket server for communicating with supercollider when using the desktop app.

@felixroos
Copy link
Collaborator

amazing, just tested it and works like a charm!

only thing I noticed is that when you exit sclang while the desktop app is running, this error is logged to the console:

thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 61, kind: ConnectionRefused, message: "Connection refused" }', src/oscbridge.rs:67:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

after that, it only works again after the app has been restarted. maybe there could be some reconnect polling logic when the connection is lost / not found. but I guess that could also be a separate PR.

@daslyfe
Copy link
Collaborator Author

daslyfe commented Sep 4, 2023

Hmm it looks like It is forcing the thread to panic if a message fails to send (which we probably dont want). I fixed the behavior. Does that fix things on your end as well?

@felixroos
Copy link
Collaborator

Hmm it looks like It is forcing the thread to panic if a message fails to send (which we probably dont want). I fixed the behavior. Does that fix things on your end as well?

yep works! getting "OSC Message failed to send, the server might no longer be available" and it also works again when I restart it! so merge this then?

@daslyfe
Copy link
Collaborator Author

daslyfe commented Sep 4, 2023

yup! go for it

@felixroos felixroos merged commit 133a1d2 into tidalcycles:main Sep 4, 2023
1 check passed
@daslyfe daslyfe deleted the tauri_osc_support branch January 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants