Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style issues #781

Merged
merged 1 commit into from Nov 5, 2023
Merged

fix: style issues #781

merged 1 commit into from Nov 5, 2023

Conversation

felixroos
Copy link
Collaborator

fixes #778 + some other style problems, e.g. the viz was hidden behind the code.

It seems the style resolution changed once again after updating astro to version 4.. related: #568

it seems that the dev server is behaving differently compared to the production version:

  • in dev, styles are scoped to where they are imported, e.g. MiniRepl.css only affects MiniRepl.jsx where it is imported
  • in production, styles are global, so everything in MiniRepl.css is affecting the whole page. this was different before..

I fixed it by adding an extra class for the mini repl container to be able to namespace all the related styles in MiniRepl.css

At some point it might make sense to dive deeper into how styles should be properly used, but for now, it is a quick fix

@felixroos felixroos merged commit 83fec57 into main Nov 5, 2023
2 checks passed
@felixroos felixroos deleted the fix-styles branch November 5, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

line numbers broken
1 participant