Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create phaser effect #798

Merged
merged 19 commits into from Nov 13, 2023
Merged

Create phaser effect #798

merged 19 commits into from Nov 13, 2023

Conversation

daslyfe
Copy link
Collaborator

@daslyfe daslyfe commented Nov 8, 2023

No description provided.

@felixroos
Copy link
Collaborator

felixroos commented Nov 8, 2023

this sounds really good! what about adding a shortcut for the phaser controls? Like:

  • ph for phaser
  • phf or phs for phasersweep
  • phc for phasercenter
  • phd for phaserdepth

@felixroos
Copy link
Collaborator

another idea would be to be able to expose numStages and fOffset as params

@daslyfe
Copy link
Collaborator Author

daslyfe commented Nov 9, 2023

Cool, I can update it to add those additional params. Is there a preferred method for adding shortcuts for superdough?

@felixroos
Copy link
Collaborator

I've added the synonyms + a doc entry.
Each string in the array of controls.mjs creates an alias. The first one is the one being set on the Hap.
You can also use an array for the first one, which will create a control that can set multiple keys at once using array / ":" notation.
Not entirely sure if we really need numStages and fOffset as params? Maybe it gets confusing if there are too many params?

@daslyfe
Copy link
Collaborator Author

daslyfe commented Nov 9, 2023

I didn’t know you could define shortcuts that way, it’s clever! I don’t necessarily think patterning stages or foffset changes the sound enough to be very useful. They would be more pronounced if a feedback stage was added in the future. An idea I had for improving it in the future would be able to define different “models” based on different hardware phasers and set the parameters based on the model.

@felixroos
Copy link
Collaborator

ok so just merge it as is?

@daslyfe
Copy link
Collaborator Author

daslyfe commented Nov 13, 2023

Yep sounds good

@felixroos felixroos merged commit 1aaaaba into tidalcycles:main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants