Add in fixes from my fork to slashocalypse branch #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a cherry-pick of my fixes as described in #832 to address that issue.
In addition to that, I reworked the custom rehype plugin
so that it catches more potential edge-cases, like if someone didn't have a leadingEdit: I reverted this part after discussion in favor of a simpler parsing method that does require relative links to have leading forward slashes./in a relative URL (which is still valid). It is named and described a little more accurately too after the new functionality.Also of minor note: for a reason I don't know exactly, inline HTML src and href urls are not being passed to the rehype plugin function, so to fix the inline image in the MDX doc, I changed it to a markdown image link and wrapped that in the HTML.