Fix edge case with rehype-urls and trailing slashes in image file paths #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another #832 add-on. 馃珷
Because of the way Github Pages serves images, it looks like they don't ignore trailing slashes i.e.
https://site.com/image.pngis served buthttps://site.com/image.png/is not. Unfortunately this is different than the localhost server behavior where the slash is ignored so I didn't see this behavior until it went "live."Thus, the rehype plugin needs to check if the url's resource path has a file extension and make sure not to add a trailing slash if it does. I do this rather primitively by checking if there is a
'.'anywhere in the url pathname. Seems to work fine. I also added back in the serialized parameter subsection of urls just in case that's needed in the future.