bugfix: sound select indexes out of bounds #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixroos
reviewed
Dec 27, 2023
packages/soundfonts/fontloader.mjs
Outdated
| import { getAudioContext, registerSound, getEnvelope } from '@strudel.cycles/webaudio'; | ||
| import gm from './gm.mjs'; | ||
| import { getSoundIndex } from '../superdough/util.mjs'; |
There was a problem hiding this comment.
iirc relative imports from another package might break stuff. to be safe, this should either be importing from @strudel.cycles/superdough (and make sure it's exported)
There was a problem hiding this comment.
I couldn't get that import to work, so I just added the function to the utils in core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round n to the nearest integer for selecting sounds, negative numbers will now select from the end of the sound array.
Examples:
sound("gm_electric_guitar_muted!4").n(saw.range(-2, 12).slow(2))
sound("bd!8").n(saw.range(0, 8).slow(1))