Refactor cps functions #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #932 , the remaining functions that depend on scheduler cps (
fit/loopAt) are now receiving the cps through pattern state, which gets the cps from the scheduler at query time.Additionally, the functions that interact with the scheduler (
all,hush,setcps,setcpm) did not work with multiple repls on the same page, because the last repl that was initialized got to set those functions on the eval scope. so any of those functions running in another repl would interact only with the last loaded scheduler. i fixed this by setting the functions on the eval scope right before evaluation, to make sure the Pattern is talking to the correct scheduler. This still feels a bit hacky, but it should work reliably (as long as 2 repls are not evaluated simultaneously)this fixes the most annoying part of #922 so I've also now added mini repls to the community bakery