use ireal as default voicing dict #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add global way to set and reset default dict
+ add mechanism to get a module by name from dynamic imports
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sets
irealas the default dictionary, as it supports much more voicings than the old one.To not break old patterns that implicitly use the old default, there is now
setDefaultVoicings('legacy')that could be tacked on automatically to all patterns in the database, or as a quick fix for the personal collection.edit: I've prepended this line to all patterns in the database that were containing the string
.voicing():the typeof check is to make sure it still works on older versions