Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support assign command #11

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Conversation

sunl888
Copy link
Contributor

@sunl888 sunl888 commented Mar 28, 2020

UCP: #6

Signed-off-by: wq1019 2013855675@qq.com

What problem does this PR solve?

Support assign issue to contributor.

What is changed and how it works?

Call GitHub API.

Check List

Tests

  • No Test

Signed-off-by: wq1019 <2013855675@qq.com>
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2020

@wq1019, you already got 200 points from easy level tasks when all pull requests merged. And you will not get score from this PR.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2020

Thanks for your pull request. Pick up issue #7 and reopen this PR

@sre-bot sre-bot closed this Mar 28, 2020
@sunl888
Copy link
Contributor Author

sunl888 commented Mar 28, 2020

@wq1019, you already got 200 points from easy level tasks when all pull requests merged. And you will not get score from this PR.

😒 👎

@you06
Copy link
Contributor

you06 commented Mar 30, 2020

@wq1019 Thanks for this PR, don't worry I'm fixing it. 😥

@you06 you06 reopened this Mar 30, 2020
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 30, 2020

@wq1019, you already got 200 points from easy level tasks when all pull requests merged. And you will not get score from this PR.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 30, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 100 points.

@you06
Copy link
Contributor

you06 commented Mar 30, 2020

@wq1019, you already got 200 points from easy level tasks when all pull requests merged. And you will not get score from this PR.

No, you will get points from this PR, sorry for this accident.

@@ -37,7 +37,8 @@ func (c *CommandRedeliver) ProcessIssueCommentEvent(event *github.IssueCommentEv
if !strings.Contains(comment, "/run") &&
!strings.Contains(comment, "/test") &&
!strings.Contains(comment, "/bench") &&
!strings.Contains(comment, "/release") {
!strings.Contains(comment, "/release") &&
!strings.Contains(comment, "/assign") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think /assign does not need to be repeated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'll fix it.

Signed-off-by: wq1019 <2013855675@qq.com>
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@you06 you06 merged commit 53734a3 into tidb-incubator:master Mar 30, 2020
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 30, 2020

Team 走进新时代 complete task #6 and get 100 score, currerent score 300

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 30, 2020

Congratulations, you get 300 score from easy level tasks in challenge program season-2, and if your PRs in reviewed stage all got merged, the score will be 300, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

@you06
Copy link
Contributor

you06 commented Mar 30, 2020

Congratulations, you get 300 score from easy level tasks in challenge program season-2, and if your PRs in reviewed stage all got merged, the score will be 300, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

Oh I should remove the limitation in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants