Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYC bus app not showing up in app yet #231

Closed
samandmoore opened this issue Mar 5, 2022 · 11 comments · Fixed by #232
Closed

NYC bus app not showing up in app yet #231

samandmoore opened this issue Mar 5, 2022 · 11 comments · Fixed by #232

Comments

@samandmoore
Copy link
Contributor

Hi!

I saw the NYC bus app that I made was merged a while ago but I'm still not seeing it in the app to setup. I'm seeing some other apps merged around the same time though.

Is there an issue with the bus app preventing it from getting enabled?

Thanks!

@rohansingh
Copy link
Member

Hi Sam. Unfortunately the app doesn't seem to be rendering for any of the stops that I tried when testing:

Screenshot_20220304-211701

@samandmoore
Copy link
Contributor Author

samandmoore commented Mar 5, 2022

That's odd! Let me investigate. It's weird because I have been running it locally for a month. Though not with the schema layer on top.

Does it log anything when it doesn't render? I'd expect that the API must be erroring or it's failing to decrypt the secret?

@rohansingh
Copy link
Member

The secret definitely decrypts and works fine since we're able to see the list of stops and pick stops. Here's the error log:

Screenshot_20220305-065259

@rohansingh
Copy link
Member

I see the same things with all the stops I've tried around our office at 544 Park Ave in Brooklyn.

@samandmoore
Copy link
Contributor Author

weird! I'm running it locally right now with that stop and it's working 😬

image

@samandmoore
Copy link
Contributor Author

lemme look closer at the bus API responses to see if there's some reason that key might be missing.

@rohansingh
Copy link
Member

OK, head scratcher for sure. There must be something with our server environment that's different. I'll have to try it on my dev server and report back.

@rohansingh
Copy link
Member

The preview with example stop code works so there might be some issue in how we're propagating the config.

Screenshot_20220305-070108

@rohansingh
Copy link
Member

OK, I see the issue. Please check out the last bit in the documentation for LocationBased that shows what to expect from config.get:
https://github.com/tidbyt/pixlet/blob/main/docs/schema/schema.md#locationbased

Here's an example of how this is handled in the LIRR app:

station_id = json.decode(station_id)["value"]

@samandmoore
Copy link
Contributor Author

ah crap! that's my bad. missed that in the docs. will fix that up right now.

@betterengineering
Copy link
Contributor

betterengineering commented Mar 5, 2022

This has been launched! Thanks again @samandmoore and so sorry for the back and forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants