nycbus: fix schema usage and some small improvements #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix issue reading stop_code from LocationBased schema * ensure time.now is always in new york time zone * do some more logging if there's an issue with the json response * show something when there's no buses * gracefully handle when there's only one bus
samandmoore
requested review from
betterengineering,
rohansingh and
matslina
as code owners
samandmoore
commented
Mar 5, 2022
| if stop_code == None: | ||
| stop_code = EXAMPLE_STOP_CODE | ||
| else: | ||
| stop_code = json.decode(stop_code)["value"] |
There was a problem hiding this comment.
this is the relevant bit for #231
rohansingh
reviewed
Mar 5, 2022
|
|
||
| if api_key: | ||
| journeys = get_journeys(api_key, stop_code) | ||
| else: | ||
| journeys = PREVIEW_DATA | ||
|
|
||
| first_journey = journeys[0] | ||
| second_journey = journeys[1] | ||
| if journeys == None or len(journeys) == 0: |
There was a problem hiding this comment.
Python shorthand for this:
Suggested change
| if journeys == None or len(journeys) == 0: | |
| if not journeys: |
betterengineering
approved these changes
Mar 5, 2022
There was a problem hiding this comment.
Thanks for the fixes @samandmoore! So sorry for not reaching out about the changes needed. Will give this a go and follow up on the issue once it's out.
|
Thanks for merging. No worries. I know y'all are probably quite busy. I'm happy I can contribute! Hopefully it works this time 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular
one bus
no buses
fixes #231
cc @rohansingh