Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Olympic Medals: add option to track a specific country #2569

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

danielsitnik
Copy link
Contributor

This update adds a second display option to the app where the user can track the medals of a specific country.

Preview:
olympic_medals

@tidbyt
Copy link

tidbyt bot commented Jul 30, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@tim-hanssen
Copy link
Contributor

We need this 🥇

@matslina matslina merged commit f61eaaf into tidbyt:main Jul 31, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Aug 3, 2024
@danielsitnik danielsitnik deleted the feature/olympic-medals-country branch September 30, 2024 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants