Leverage validate_slippage from primitives
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify Oracle pallet Simplify tests as well, as from now we could fuzz the function directly Signed-off-by: david <david@lemarier.ca>
lemarier
added
A0-pleasereview
Signed-off-by: david <david@lemarier.ca>
Signed-off-by: david <david@lemarier.ca> # Conflicts: # Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Oracle pallet and tests for better readability
The primitives logic can be found here;
https://github.com/tidelabs/primitives/blob/dev/primitives/src/swap/swap.rs
This also include a nightly fuzzer that run on Github actions every day (in the primitives).
This is an example how we could use
tidextto validate slippage of 2 swaps based on an amount to fulfill.https://github.com/tidelabs/tidext/blob/98b6bbe038241a83c56482b6bb3e73d76cabe842/examples/examples/swap.rs#L180-L183
Signed-off-by: david david@lemarier.ca