This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
Changes to add annotations for mismatched settings #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
added a commit
that referenced
this pull request
Mar 13, 2014
Changes to add annotations for mismatched settings. LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pump gets reset, it loses continuity in the flow of the settings, which causes the validity checks that were in place to fail. This fix changes it so that instead of failing, we assume the new data is good and annotate the event (and all subsequent events as the change will cascade) that we are making an assumption.
The intent is that this annotation will be visible on each datum such that it can be exposed in a visualization. @kentquirk lmk what you think.