Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trends misc tweaks #54

Merged
merged 14 commits into from Feb 14, 2017
Merged

Conversation

jebeck
Copy link
Contributor

@jebeck jebeck commented Feb 7, 2017

This should be the final PR for the current Trends feature changes, contains a few styling tweaks/fixes and a substantive bugfix for "stuck" hover labels after clicking thru to Daily and then back to Trends, which I solved by clearing all focused state on componentWillUnmount.

Stacked on #53 again for diffing convenience.

@jebeck jebeck requested a review from hntrdglss February 7, 2017 21:18
@jebeck
Copy link
Contributor Author

jebeck commented Feb 7, 2017

@jebeck jebeck requested review from krystophv and removed request for hntrdglss February 8, 2017 20:49
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

handle display of out-of-range BGs on Trends
@jebeck jebeck merged commit c7c3b68 into jebeck/trends-bgm-changes.2 Feb 14, 2017
@jebeck jebeck deleted the jebeck/trends-misc-tweaks branch February 14, 2017 00:41
@jebeck jebeck mentioned this pull request Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants