[ALOY-1355] Fixed issue where attributes containing 'true' or 'false'…

[cb1kenobi]

… where being treated as strings instead of booleans. There's no way for Alloy to know if the attribute really is a boolean or not, so we have to blindly test for 'true' and 'false'. This isn't ideal. If someone has a label of 'true', then it will be cast as a bool, but should be cast back to a string when used in the context of a string value.

[FokkeZB]

Actually, same is true for numbers. I you do <TabbedBar index=0> it will be a "0" string currently, while it should clearly be a 0 Number.

@cb1kenobi could you update the PR so it also handles that? Then it resolves https://jira.appcelerator.org/browse/ALOY-1324 as well (which talks about both boolean and number). I have no idea if we can see if one uses <TabbedBar index=0> or <TabbedBar index="0"> in the XML but at least in the last case it should be a Number.

Perhaps we could even do the same with boolean? I've tested that <View visible=false> compiles OK. So if there's a way we can see quotes have been used then that would be a great way to know if we should cast the value. Then it wouldn't be a possible breaking change.

jindw/xmldom#156

[cb1kenobi]

@FokkeZB Fixed. :)

[skypanther]

Last I checked, if you used something like <View visible=false/> Alloy would output a warn in the logs. If that is going to be acceptable XML, the logging should be updated to accommodate it. Maybe that's from xmldom?

[FokkeZB]

@skypanther it is coming from xmldom.

See https://jira.appcelerator.org/browse/ALOY-1355?focusedCommentId=376959&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-376959

[feons]

Looks good. Approved.