You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description:
Remove implicit iOS namespace for Toolbar.
Add Android alloy parser for Toolbar.
I believe this would keep the backward compatibility for iOS since the new code is used only when the Toolbar is used as a custom ActionBar (which we will alloy only for Android). If we can further guard for that we could add that as well.
@feons Can we keep it until 8.0.0? Otherwise it will be a breaking change for Alloy, although we still support the tag. It's deprecated in 6.2.0 and will be removed in 8.0.0.
The reason will be displayed to describe this comment to others. Learn more.
CR / FT passed. Left some feedback about the general toolbar-implementation (not auto-filling by default), but this is Alloy-unrelated and could be addressed in a later release or 6.2.0.GA.
most importantly, there are quite a number of references to Ti.UI.iOS.Toolbar in the code base that are not taken care of, i.e sample code with Ti.UI.iOS.Toolbar usage does cause confusion; this probably won't work <Toolbar><Items> ... </Items></Toolbar> anymore.
@feons Sorry for merging too early then! Should I create a ticket? The old toolbar still works for me, but please do another test to verify, that'd be awesome!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25003
Description:
Remove implicit iOS namespace for Toolbar.
Add Android alloy parser for Toolbar.
I believe this would keep the backward compatibility for iOS since the new code is used only when the Toolbar is used as a custom ActionBar (which we will alloy only for Android). If we can further guard for that we could add that as well.