Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALOY-1646] Add support for platform specific namespaces for xml attributes #922

Merged
merged 8 commits into from
Mar 29, 2019
Merged

[ALOY-1646] Add support for platform specific namespaces for xml attributes #922

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3004acf
Merge remote-tracking branch 'upstream/master'
brentonhouse Jan 22, 2019
9d7f80a
Merge remote-tracking branch 'upstream/master'
brentonhouse Mar 7, 2019
a84b61b
added support for platform specific namespaces for xml attributes
brentonhouse Mar 7, 2019
d281ff1
Merge remote-tracking branch 'upstream/master' into ALOY-1646
brentonhouse Mar 28, 2019
620a974
moved logic to compilerUtils
brentonhouse Mar 28, 2019
0b549a0
fixed attrName
brentonhouse Mar 28, 2019
a872ff8
fixed issues with platform attributes
brentonhouse Mar 28, 2019
54c5a26
Update Alloy/commands/compile/compilerUtils.js
ewanharris Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions Alloy/commands/compile/parsers/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,17 @@ function parse(node, state, args) {
args.symbol = CU.generateUniqueId();
}

// find platform specific attributes
var platformAttributes = _.filter(_.keys(args.createArgs), key => _.includes(key, ':'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than looping through all the keys again in this file, I think it would be better to do this in the initial pass in compilerUtils.getParserArgs. Filtering out any args that aren't for the platform and removing the platform prefix from the attribute.

_.forEach(platformAttributes, attribute => {
var attributeParts = attribute.split(':');
// if this attribute is for this platform, create it without namespace.
if ( attributeParts[0] === platform ) {
args.createArgs[attributeParts[1]] = args.createArgs[attribute];
}
delete args.createArgs[attribute];
});

// Generate runtime code
if (state.isViewTemplate) {
var bindId = node.getAttribute('bindId');
Expand Down