Build improvements

.eslintignore

@@ -0,0 +1,10 @@
+node_modules
+
+android/bin/
+android/build/
+android/dist/
+ios/build/
+ios/dist/
+
+# These should eventually be linted as well
+example/

.eslintrc

@@ -0,0 +1,16 @@
+{
+  "extends": [ "axway/env-titanium", "axway/env-node" ],
+  "parserOptions": {
+    "ecmaVersion": 2015,
+    "sourceType": "script"
+  },
+  "overrides": [
+    {
+      "files": [ "dangerfile.js" ],
+      "parserOptions": {
+        "ecmaVersion": 2017,
+        "sourceType": "module"
+      }
+    }
+  ]
+}

android/.clang-format

@@ -0,0 +1,26 @@
+---
+Language: Java
+AccessModifierOffset: -4
+AllowShortBlocksOnASingleLine: false
+AllowShortFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+# class, constructor, method should be next line
+BreakBeforeBraces: Linux
+# Keep '=' at end of line when wrapping, but move things like '&&', '||' to beginning of newline
+BreakBeforeBinaryOperators: NonAssignment
+# FIXME: break for brace after synchronized block, anonymous class declarations
+BreakAfterJavaFieldAnnotations: true
+ColumnLimit: 120
+IndentCaseLabels: true
+IndentWidth: 4
+MaxEmptyLinesToKeep: 1
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpacesInParentheses: false
+TabWidth: 4
+UseTab: ForContinuationAndIndentation
+SpaceAfterCStyleCast: true
+# Spaces inside {} for array literals, i.e. "new Object[] { args }"
+Cpp11BracedListStyle: false
+ReflowComments: false

android/src/appcelerator/encrypteddatabase/EncrypteddatabaseModule.java

@@ -30,7 +30,8 @@
 import net.sqlcipher.database.SQLiteDatabaseHook;
 
 @Kroll.module(name = "Encrypteddatabase", id = "appcelerator.encrypteddatabase")
-public class EncrypteddatabaseModule extends KrollModule {
+public class EncrypteddatabaseModule extends KrollModule
+{
 	private static final String TAG = "TiDatabase";
 	private String password = null;
 
@@ -45,30 +46,43 @@ public class EncrypteddatabaseModule extends KrollModule {
 	@Kroll.constant
 	public static final int FIELD_TYPE_DOUBLE = 3;
 
-	public EncrypteddatabaseModule() {
+	public EncrypteddatabaseModule()
+	{
 		super();
 		SQLiteDatabase.loadLibs(TiApplication.getAppCurrentActivity());
 	}
 
-	@Kroll.getProperty @Kroll.method
-	public String getPassword() {
+	// clang-format off
+	@Kroll.getProperty
+	@Kroll.method
+	public String getPassword()
+	// clang-format on
+	{
 		return password == null ? TiApplication.getInstance().getAppGUID() : password;
 	}
 
-	@Kroll.setProperty @Kroll.method
-	public void setPassword(String value) {
+	// clang-format off
+	@Kroll.getProperty
+	@Kroll.method
+	public void setPassword(String value)
+	// clang-format on
+	{
 		password = value;
 	}
 
 	@Kroll.method
-	public TiDatabaseProxy open(Object file) {
+	public TiDatabaseProxy open(Object file)
+	{
 		// Attempt to create/open the given database file/name.
 		TiDatabaseProxy dbp = null;
 
 		// Migrate database if necessary.
 		final SQLiteDatabaseHook migrationHook = new SQLiteDatabaseHook() {
-			public void preKey(SQLiteDatabase database) {}
-			public void postKey(SQLiteDatabase database) {
+			public void preKey(SQLiteDatabase database)
+			{
+			}
+			public void postKey(SQLiteDatabase database)
+			{
 				database.rawExecSQL("PRAGMA cipher_migrate;");
 			}
 		};
@@ -81,8 +95,9 @@ public void postKey(SQLiteDatabase database) {
 			String absolutePath = tiFile.getBaseFile().getNativeFile().getAbsolutePath();
 			Log.d(TAG, "Opening database from filesystem: " + absolutePath);
 
-			SQLiteDatabase db = SQLiteDatabase.openDatabase(absolutePath, getPassword(), null,
-					SQLiteDatabase.OPEN_READONLY | SQLiteDatabase.NO_LOCALIZED_COLLATORS, migrationHook);
+			SQLiteDatabase db = SQLiteDatabase.openDatabase(
+				absolutePath, getPassword(), null, SQLiteDatabase.OPEN_READONLY | SQLiteDatabase.NO_LOCALIZED_COLLATORS,
+				migrationHook);
 			if (db != null) {
 				dbp = new TiDatabaseProxy(db);
 			} else {
@@ -110,7 +125,8 @@ public void postKey(SQLiteDatabase database) {
 	}
 
 	@Kroll.method
-	public TiDatabaseProxy install(KrollInvocation invocation, String url, String name) throws IOException {
+	public TiDatabaseProxy install(KrollInvocation invocation, String url, String name) throws IOException
+	{
 		try {
 			// TiContext tiContext = invocation.getTiContext();
 			Context ctx = TiApplication.getInstance();

android/src/appcelerator/encrypteddatabase/TiDatabaseProxy.java

@@ -21,14 +21,16 @@
 import net.sqlcipher.database.SQLiteDatabase;
 
 @Kroll.proxy(parentModule = EncrypteddatabaseModule.class)
-public class TiDatabaseProxy extends KrollProxy {
+public class TiDatabaseProxy extends KrollProxy
+{
 	private static final String TAG = "TiDB";
 
 	protected SQLiteDatabase db;
 	protected String name;
 	boolean statementLogging, readOnly;
 
-	public TiDatabaseProxy(String name, SQLiteDatabase db) {
+	public TiDatabaseProxy(String name, SQLiteDatabase db)
+	{
 		// super(tiContext);
 		super();
 		this.name = name;
@@ -38,7 +40,8 @@ public TiDatabaseProxy(String name, SQLiteDatabase db) {
 	}
 
 	// readonly database
-	public TiDatabaseProxy(SQLiteDatabase db) {
+	public TiDatabaseProxy(SQLiteDatabase db)
+	{
 		// super(tiContext);
 		super();
 		this.name = db.getPath();
@@ -48,7 +51,8 @@ public TiDatabaseProxy(SQLiteDatabase db) {
 	}
 
 	@Kroll.method
-	public void close() {
+	public void close()
+	{
 		if (db.isOpen()) {
 			Log.d(TAG, "Closing database: " + name, Log.DEBUG_MODE);
 			db.close();
@@ -58,7 +62,8 @@ public void close() {
 	}
 
 	@Kroll.method
-	public TiResultSetProxy execute(String sql, Object... args) {
+	public TiResultSetProxy execute(String sql, Object... args)
+	{
 		// Handle the cases where an array is passed containing the SQL query
 		// arguments.
 		// Otherwise use the variable argument list for the SQL query.
@@ -154,32 +159,45 @@ public TiResultSetProxy execute(String sql, Object... args) {
 		return rs;
 	}
 
+	// clang-format off
 	@Kroll.getProperty
 	@Kroll.method
-	public String getName() {
+	public String getName()
+	// clang-format on
+	{
 		return name;
 	}
 
+	// clang-format off
 	@Kroll.getProperty
 	@Kroll.method
-	public TiFileProxy getFile() {
+	public TiFileProxy getFile()
+	// clang-format on
+	{
 		return new TiFileProxy(TiFileFactory.createTitaniumFile(db.getPath(), false));
 	}
 
+	// clang-format off
 	@Kroll.getProperty
 	@Kroll.method
-	public int getLastInsertRowId() {
+	public int getLastInsertRowId()
+	// clang-format on
+	{
 		return (int) DatabaseUtils.longForQuery(db, "select last_insert_rowid()", null);
 	}
 
+	// clang-format off
 	@Kroll.getProperty
 	@Kroll.method
-	public int getRowsAffected() {
+	public int getRowsAffected()
+	// clang-format on
+	{
 		return (int) DatabaseUtils.longForQuery(db, "select changes()", null);
 	}
 
 	@Kroll.method
-	public void remove() {
+	public void remove()
+	{
 		if (readOnly) {
 			Log.w(TAG, name + " is a read-only database, cannot remove");
 			return;
@@ -196,5 +214,4 @@ public void remove() {
 			Log.w(TAG, "Unable to remove database, context has been reclaimed by GC: " + name);
 		}
 	}
-
 }