Skip to content

Commit

Permalink
Merge pull request #212 from hansemannn/TIMOB-25283
Browse files Browse the repository at this point in the history
[TIMOB-25283] Deprecate "thirdparty" section in appc.js
  • Loading branch information
janvennemann committed Sep 25, 2017
2 parents ad52512 + e4da396 commit 7942bd4
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion iphone/plugin/hyperloop.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ HyperloopiOSBuilder.prototype.processThirdPartyFrameworks = function processThir
}

/**
* Processes third-party dependencies that are configured in appc.js under the
* Processes third-party dependencies that are configured in
under the
* hyperloop.ios.thirdparty key
*
* These can be both uncompiled Swift and Objective-C source files as well as
Expand Down Expand Up @@ -589,6 +590,9 @@ HyperloopiOSBuilder.prototype.generateSourceFiles = function generateSourceFiles
addSearchPathsFromCocoaPods(extraFrameworkSearchPaths, this.cocoaPodsBuildSettings.FRAMEWORK_SEARCH_PATHS);
}
if (this.hyperloopConfig.ios.thirdparty) {
// Throw a deprecation warning regarding thirdparty-references in the appc.js
this.logger.warn('Defining third-party sources and frameworks in appc.js via the \'thirdparty\' section has been deprecated in Hyperloop 2.2.0 and will be removed in 3.0.0. The preferred way to provide third-party sources is either via dropping frameworks into the project\'s platform/ios folder or by using CocoaPods.');

this.headers = [];
Object.keys(this.hyperloopConfig.ios.thirdparty).forEach(function(frameworkName) {
var thirdPartyFrameworkConfig = this.hyperloopConfig.ios.thirdparty[frameworkName];
Expand Down

0 comments on commit 7942bd4

Please sign in to comment.