[TIMOB-23144] Fixed crash on device and swift code compiler for device #12
Conversation
# Conflicts: # iphone/titanium/HyperloopModule.m
| // the device build needs to know the target for the ast-dump | ||
| if (sdkPath.indexOf('Simulator') == -1) { | ||
| args.push('-target'); | ||
| args.push('armv7-apple-ios7.1'); |
There was a problem hiding this comment.
We need to find a way to get the target more generically, the rest looks great!
There was a problem hiding this comment.
@pec1985 This is not going to be easy, but here's the best approach so far:
From what i understand, there's only 3 possible options for target:
arm64-apple-ios<deployment version> ,armv7-apple-ios<deployment version>, armv7s-apple-ios<deployment version>
in this case, deployment version relates to our minVersion, which is '7.1' and can be obtained here inside metadata.
https://github.com/appcelerator/hyperloop.next/blob/master/iphone/plugin/hyperloop.js#L498
So my suggestion is instead of searching for the string 'simulator' you should be looking at metadata.sdkType, and do a string combination of arm64-apple-ios<metadata.minVersion>
Reference link: https://marc.ttias.be/swift-users/2016-02/msg00277.php
There was a problem hiding this comment.
another reason why we should NOT hard code 7.1
https://jira.appcelerator.org/browse/TIMOB-23172
There was a problem hiding this comment.
Have the Hyperloop CLI plugin pass the Xcode version in. From the iOS Hyperloop build implementation, you have this.builder which is the Titanium iOS build state. There's a property called xcodeEnv on the builder object that contains the info for the selected Xcode used to build. Just pass this.builder.xcodeEnv.version into the metabase call.
Note that this is probably in the format X.Y, but not guaranteed.
There was a problem hiding this comment.
Yep, just tested. It returns 7.3.
|
Closing PR since the issues here were already addressed in other tickets |
https://jira.appcelerator.org/browse/TIMOB-23144