Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25059] Use module hooks instead of plugins #254

Merged
merged 9 commits into from
Nov 9, 2017
Merged

[TIMOB-25059] Use module hooks instead of plugins #254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
733d94b
[TIMOB-25059] Use module hooks instead of plugins
janvennemann Nov 2, 2017
32d5df1
[TIMOB-25059] Remove plugin handling from Windows build
janvennemann Nov 2, 2017
1ff1488
[TIMOB-25059] Build against SDK 7.0.0
janvennemann Nov 2, 2017
8084800
[TIMOB-25059] Remove metabase binary
janvennemann Nov 2, 2017
c2208b2
[TIMOB-25059] Warn about legacy plugin usage
janvennemann Nov 2, 2017
412be04
[TIMOB-25059] Add JS docs
janvennemann Nov 2, 2017
5caacc1
Merge branch 'master' into TIMOB-25059
janvennemann Nov 2, 2017
e2225b8
[TIMOB-25059] Rephrase error message
janvennemann Nov 7, 2017
893cf60
Merge branch 'master' into TIMOB-25059
janvennemann Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion hooks/hyperloop-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,17 @@
const fs = require('fs');
const path = require('path');

exports.id = 'com.appcelerator.hyperloop';
exports.id = 'com.appcelerator.hyperloop.init';
exports.cliVersion = '>=3.2';
exports.init = (logger, config, cli, appc) => {
cli.on('cli:check-plugins', () => {
for (const plugin of cli.tiapp.plugins) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use forEach here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to use for...of whenever possible because it allows break and continue logic and doesn't overrides the context because no new function is created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine then

if (plugin.id === 'hyperloop') {
logger.error('Legacy Hyperloop plugin detected! Please remove any references to the Hyperloop plugin tag from your tiapp.xml. Since Hyperloop 3.0 you only need to enable it as a module.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe phrase it Hyperloop "<plugin>" tag ?

process.exit(1);
}
}
});
cli.on('build.pre.compile', {
priority: 1300,
post: function (builder, callback) {
Expand Down
Binary file removed packages/hyperloop-ios-metabase/bin/metabase
View file
Open in desktop
Binary file not shown.