[TIMOB-25059] Use module hooks instead of plugins #254
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| 'use strict'; | ||
|
|
||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| exports.id = 'com.appcelerator.hyperloop.init'; | ||
| exports.cliVersion = '>=3.2'; | ||
| exports.init = (logger, config, cli, appc) => { | ||
| cli.on('cli:check-plugins', () => { | ||
| for (const plugin of cli.tiapp.plugins) { | ||
| if (plugin.id === 'hyperloop') { | ||
| logger.error('Legacy Hyperloop plugin detected! Please remove any references to the Hyperloop plugin tag from your tiapp.xml. Since Hyperloop 3.0 you only need to enable it as a module.'); | ||
|
There was a problem hiding this comment. Maybe phrase it |
||
| process.exit(1); | ||
| } | ||
| } | ||
| }); | ||
| cli.on('build.pre.compile', { | ||
| priority: 1300, | ||
| post: function (builder, callback) { | ||
| const factory = new HyperloopBuilderFactory(logger, config, cli, appc, builder); | ||
| const instance = factory.createHyperloopBuilder(); | ||
| instance.init(callback); | ||
| } | ||
| }); | ||
| }; | ||
|
|
||
| class HyperloopBuilderFactory { | ||
| constructor(logger, config, cli, appc, builder) { | ||
| this.logger = logger; | ||
| this.config = config; | ||
| this.cli = cli; | ||
| this.appc = appc; | ||
| this.builder = builder; | ||
| } | ||
|
|
||
| createHyperloopBuilder() { | ||
| const hyperloopConfig = this.loadConfiguration(); | ||
| const platformHookFile = path.join(__dirname, 'hyperloop.js'); | ||
|
|
||
| if (!fs.existsSync(platformHookFile)) { | ||
| this.logger.error(`Hyperloop builder not found at expected path ${platformHookFile}.`); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| var Builder = require(platformHookFile); | ||
| return new Builder(this.logger, this.config, this.cli, this.appc, hyperloopConfig, this.builder); | ||
| } | ||
|
|
||
| loadConfiguration() { | ||
| const possibleConfigurtionFiles = [ | ||
| path.join(this.builder.projectDir, 'appc.js'), | ||
| path.join(this.builder.projectDir, '.appc.js'), | ||
| path.join(process.env.HOME || process.env.USERPROFILE, '.appc.js') | ||
| ]; | ||
| let config = {}; | ||
|
|
||
| for (let configurationFile of possibleConfigurtionFiles) { | ||
| if (fs.existsSync(configurationFile)) { | ||
| this.mergeObjectProperties(config, require(configurationFile)); | ||
| } | ||
| } | ||
|
|
||
| return config; | ||
| } | ||
|
|
||
| mergeObjectProperties(target, source) { | ||
| if (!source) { | ||
| return; | ||
| } | ||
|
|
||
| for (var k in source) { | ||
| if (source.hasOwnProperty(k)) { | ||
| target[k] = source[k]; | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use
forEachhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to use
for...ofwhenever possible because it allowsbreakandcontinuelogic and doesn't overrides the context because no new function is created.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine then