-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments around the parsing sourceType but nothing major
@@ -321,7 +321,7 @@ class ScanReferencesTask extends IncrementalFileTask { | |||
}; | |||
|
|||
// Now traverse the AST and generate modified source | |||
const ast = babylon.parse(originalSource, { sourceFilename: file, sourceType: 'module' }); | |||
const ast = babelParser.parse(originalSource, { sourceFilename: file, sourceType: 'module' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-titanium-sdk has started parsing using unambiguous sourceType as opposed to assuming everything is an ESModule, might be worthwhile doing that here too
iphone/hooks/generate/custom.js
Outdated
@@ -594,7 +594,7 @@ Parser.prototype.parse = function (buf, fn, state) { | |||
// turn it into a buffer | |||
buf = buf.toString(); | |||
|
|||
const ast = babylon.parse(buf, { sourceFilename: fn, sourceType: 'module' }); | |||
const ast = babelParser.parse(buf, { sourceFilename: fn, sourceType: 'module' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
iphone/hooks/hyperloop.js
Outdated
@@ -597,11 +597,11 @@ HyperloopiOSBuilder.prototype.patchJSFile = function patchJSFile(obj, sourceFile | |||
} | |||
}; | |||
|
|||
const ast = babylon.parse(contents, { sourceFilename: sourceFilename, sourceType: 'module' }); | |||
const ast = babelParser.parse(contents, { sourceFilename: sourceFilename, sourceType: 'module' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Merge with master and update Windows babel deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
JIRA: https://jira.appcelerator.org/browse/TIMOB-23468