ci: use nodejs 10.17.0 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a slew of issues around the mock-fs module with node 10, working to update that and ensure the tests keep passing |
Fixes issues with tests on newer node versions
npm appears to be leaving being invalid symlinks in the .bin directory which is then causing issues during module build
ewanharris
commented
Dec 16, 2019
| @@ -83,6 +83,7 @@ stage('Build') { | |||
| dir('hooks') { | |||
| sh 'npm ci' | |||
| sh 'npm test' | |||
| sh 'rm -rf node_modules' | |||
There was a problem hiding this comment.
npm ci should do this, but something is going wrong and it leaves files in .bin pointing to files that no longer exist 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are failing as the selected SDK (9.x) errors out due to node 8.16.0 being used when trying to select 8.0.2.GA for use