Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): handle no android ndk being installed #333

Merged
merged 1 commit into from
Feb 19, 2020
Merged

fix(android): handle no android ndk being installed #333

merged 1 commit into from
Feb 19, 2020

Conversation

ewanharris
Copy link
Contributor

Fixes TIMOB-27771

jquick-axway
jquick-axway approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway jquick-axway merged commit 18ecd6e into tidev:master Feb 19, 2020
@jquick-axway
Copy link
Contributor

jquick-axway commented Feb 19, 2020 •
edited

Oops. I merged this in too quickly. There is a typo in this PR's code change.

this.androidInfo.ndk ...should be... this.builder.androidInfo.ndk

Will be corrected via PR #335

@jquick-axway jquick-axway mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewanharris @jquick-axway