-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24021] [TIMOB-24022] (2_0_X) Fixes for Android hyperloop #85
Conversation
….content.Intent fails on SDK 6+ - use proper require paths with correct prefixes for internal hyperloop wrappers ('./' prefix)
… classes - Fix conversion of arguments to ClassProxy.newInstance when Map. Because of fix for TIMOB-23966 we always get String keys in maps, where before we relied on auto conversion to Integer
To test, try out this app: var Intent = require('android.content.Intent');
var Activity = require('android.app.Activity');
var Uri = require("android.net.Uri");
var win = Ti.UI.createWindow({
backgroundColor: "#fff"
});
var btn = Ti.UI.createButton({
title: "Trigger"
});
btn.addEventListener("click", openIntent);
win.add(btn);
win.open();
function openIntent() {
var activity = new Activity(Ti.Android.currentActivity);
var intent = Ti.Android.createIntent({
action: Ti.Android.ACTION_VIEW
});
var nativeIntent = new Intent(intent);
nativeIntent.setData(Uri.parse("sms://"));
nativeIntent.putExtra("sms_body", "Hello world!");
activity.startActivity(nativeIntent);
} |
Once approved, this PR should be cherry-picked to master as well. (but not 1_2_X) |
LGTM. Travis failed because of a timeout, so I re-triggered it. Will merge after it succeeds. Thx! |
Travis succeeds. But there are a couple of errors related to the
It indicates that Travis builds with an incorrect Swift version, so it should be checked against that. In addition, the travis build should fail if any unit-test fails. As it doesn't affect this PR and the core is still correct, I will merge this PR and it's backport. Thx! |
Specifically this fixes two issues: