Skip to content

Commit

Permalink
v1.7.14
Browse files Browse the repository at this point in the history
fix: Moved simctl and simulator executable definition from findSimulators() to detect() so that exact Xcode simctl path is coupled with each sim handle.
refactor: Revamped sim runtime lookup and added a device type lookup which eliminated a 3rd level nested for loop and simplifies valid runtime resolution.
fix: Fixed bug where non-iPhone, non-iPad, and non-Watch device types would be treated as watch devices and ultimately cause an error because Apple TV devices don't have a model number.
refactor: Removed 'isAvailable' property added in PR #93 since the correct solution is not to track availability, but separate the selected Xcode from the Xcode associated with the requested simulator.
fix: Added check to ensure watchCompanion cache only considers valid watchOS ranges.
fix: Correct sort Xcodes in findSimulators() so that the iOS version takes precedence followed by the system selected Xcode and the latest version.
fix: Select Xcode version based on specified iOS SDK version, system selected version, or latest version and don't worry about the version used to launch the simulator.
style: Removed a handful of unused variables.
fix: Fixed simulator device pair compatiblity lookup where >=4.x and >=3.2 would incorrectly include watchOS 5 and 6.
chore: Updated npm deps within minor/patch ranges.
  • Loading branch information
cb1kenobi committed Sep 18, 2019
1 parent da9340c commit 065121d
Show file tree
Hide file tree
Showing 6 changed files with 947 additions and 565 deletions.
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright 2014-2018 by Appcelerator, Inc.
Copyright 2014-2019 by Appcelerator, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
2 changes: 0 additions & 2 deletions lib/simctl.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
const appc = require('node-appc');
const async = require('async');
const debug = require('debug');
const path = require('path');
const fs = require('fs');
const __ = appc.i18n(__dirname).__;

exports.activatePair = activatePair;
Expand Down

0 comments on commit 065121d

Please sign in to comment.