Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-23620] Add device pair compatibility for Xcode 8 #37

Merged
merged 2 commits into from
Jul 28, 2016
Merged

[TIMOB-23620] Add device pair compatibility for Xcode 8 #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c85125
[TIMOB-23620] Add device pair compatibility for Xcode 8
janvennemann Jul 12, 2016
c0137d4
[TIMOB-23620] Allow watchOS 3 to be paired with iOS 9 sims
janvennemann Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/simulator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ const devicePairCompatiblity = exports.devicePairCompatiblity = {
'9.x': { // iOS 9.0
'2.x': true // watchOS 2.0
}
},
'8.x': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should set this to >=8.x to future proof us?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode typically includes the simulators for the current iOS sdk version and the previous version sims can be downloaded. If Xcode 9 come out in the future, it probably supports iOS 11 and iOS 10 sims. So we would have to edit this mapping anyway.

'>=9.0 <=9.3': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 9.x, not a range.

'2.x': true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. You CAN pair a WatchOS 3 simulator with a iOS 9 simulator. Please add '3.x': true.

'10.x': {
'2.x': true,
'3.x': true
}
}
};

Expand Down