Move to our new eslint standard, update to use let/const #104
Conversation
…shint and jscs configs
…shint and jscs configs
…abili minification
|
@sgtcoolguy I think we should look at adding some preset-env or something here, I'm not full confident in all of our supported target OS's/JS engines supporting the usage of let/const. Additionally, so as we only allow one version of liveview at at time due to us shipping in Studio I presume we would need to keep this compatible with version of the SDK at least in our current major line (6_X), and maybe even before? Excuse the drive by review if I'm missing something and this has already been discussed :) |
| require('shelljs/global'); | ||
|
|
||
| var program = require('commander'), | ||
| colors = require('coloring'), |
There was a problem hiding this comment.
This is used, eg. line 80, [ERROR]'.red
| * Module dependencies. | ||
| */ | ||
| var program = require('commander'), | ||
| colors = require('coloring'), |
| // inject shelljs to the global scope | ||
| /* globals exec */ | ||
| require('shelljs/global'); | ||
|
|
||
| var program = require('commander'), | ||
| colors = require('coloring'), |
|
|
||
| // inject shelljs to the global scope | ||
| /* globals exec */ | ||
| require('shelljs/global'); | ||
|
|
||
| var program = require('commander'), | ||
| colors = require('coloring'), |
|
liveview swapped liveview.js with app.js, liveview.js is run by the SDK. Everything under lib/platform/* will be built into liveview.js. So no const/let in those files I suppose. |
…generate liveview.es6.js and then babel to transpile down to liveview.js
|
@ewanharris @feons No, you guys are both right. I wasn't aware that the To fix that, I dumped the minify step in our grunt file because we don't ever actually use It also means we could use more es6 features in the original code (to improve maintenance/readability) and it'll all get transpiled down for us - and that eventually we could avoid transpilation or bump the min target preset used as our SDKs can handle more. |
|
I took out node 4 testing on travis because we need to set |
| fsWatcher = require('chokidar'), | ||
| colors = require('coloring'), |
|
@sgtcoolguy, |
| * @return {Array} running liveview server pid filenames | ||
| */ | ||
| FServer.pids = function (env) { | ||
| var pids = []; | ||
| let pids = []; |
There was a problem hiding this comment.
probably need to set use strict.
…to top of fserver.js
This moves to using the new appcelerator/eslint-config-axway configuration for listing the code. This involved a lot of changes to adhere.
I also moved to using
let/constin place ofvar, since the code originally was written in a way that sort of assumed block scoping forvar(I had to hoist them all up to make jshint/jscs happy in the previous round of cleanup, but they were declared/sprinkled where used, not at top of scope before this).I also updated to use node-minify via babili to minify, rather than uglifyjs (since it can't handle const/let).
Previous to this PR, I had moved from using a Makefile to using grunt and plugins to make this more like our other projects - and had moved to using appcJS to lint via jshint/jscs (which we're now moving away from to eslint)