[TIMOB-24900] Support Android O changes

[garymathews]

• Increase 100ms delay to 200ms before sending command
• Implement waitForResponse for trackDevices as the initial response may not contain any response data
• ps now requires the -A parameter to list all process results. Implement backwards-compatible adb.ps method
• Fix getPid to use new adb.ps method
• Remove -no-boot-anim as this flag prevents the Android O emulator from booting
• Increase -partition-size to 512

JIRA Ticket

[cb1kenobi]

This isn't working. When I connect a device and run the adb test, sometimes it works, but sometimes it exits if there is no device found.

$ node tests/test-adb.js
[1] CONNECTED
[1] SENDING host:track-devices
[1] RECEIVED 4 BYTES (state=1) (cmd=host:track-devices)
[1] BUFFER LENGTH = 4
[1] RESULT OKAY
[1] DONE, SETTING STATE TO WAIT_FOR_RESPONSE
[1] RECEIVED 20 BYTES (state=4) (cmd=host:track-devices)
[1] BUFFER LENGTH = 20
[1] DONE, RECEIVED RESPONSE
[1] SOCKET CLOSED BY SERVER 20
[2] CONNECTED
[2] SENDING host:transport:001006de0b00
[2] RECEIVED 4 BYTES (state=1) (cmd=host:transport:001006de0b00)
[2] BUFFER LENGTH = 4
[2] RESULT FAIL
[2] ERROR!
[2] RECEIVED 35 BYTES (state=0) (cmd=host:transport:001006de0b00)
[2] SOCKET CLOSED BY SERVER null
[3] CONNECTED
[3] SENDING host:transport:192.168.56.101:5555
[3] RECEIVED 4 BYTES (state=1) (cmd=host:transport:192.168.56.101:5555)
[3] BUFFER LENGTH = 4
[3] RESULT FAIL
[3] ERROR!
[3] RECEIVED 42 BYTES (state=0) (cmd=host:transport:192.168.56.101:5555)
[3] SOCKET CLOSED BY SERVER null
[4] CONNECTED
[4] SENDING host:transport:192.168.56.101:5555
[4] RECEIVED 46 BYTES (state=1) (cmd=host:transport:192.168.56.101:5555)
[4] BUFFER LENGTH = 46
[4] RESULT FAIL
[4] ERROR! device '192.168.56.101:5555' not found
Devices:
[ { id: '001006de0b00', state: 'device', emulator: false } ]

[4] SOCKET CLOSED BY SERVER null

I tried testing it before your changes and it also isn't working as expected. It doesn't find the connected device the first time, but it also doesn't exit and continues to listen for devices.

I'm starting to think maybe we should switch to something like adbkit.

[garymathews]

@cb1kenobi Updated PR

[cb1kenobi]

ps -A does nothing on my device.

chris@yojimbo (tmp):~/appc/node-titanium-sdk$ adb shell
shell@flo:/ $ ps -A
USER      PID   PPID  VSIZE  RSS   WCHAN            PC  NAME
shell@flo:/ $
shell@flo:/ $ ps
USER      PID   PPID  VSIZE  RSS   WCHAN            PC  NAME
root      1     0     2216   820   sys_epoll_ 00000000 S /init
root      2     0     0      0       kthreadd 00000000 S kthreadd
root      3     2     0      0     run_ksofti 00000000 S ksoftirqd/0
root      6     2     0      0     cpu_stoppe 00000000 S migration/0
root      16    2     0      0     rescuer_th 00000000 S khelper
root      17    2     0      0     rescuer_th 00000000 S suspend_sys_syn
root      18    2     0      0     rescuer_th 00000000 S suspend
root      23    2     0      0     irq_thread 00000000 S irq/203-msmdata
<snip>

I see you are checking if the output prints an error, but running ps -A on my device does not display an error. You basically need to check for the bad pid '-A' OR if it just returned the header. Maybe even run ps by default and fallback to ps -A if needbe.

[garymathews]

Interesting, what Android OS are you running?

[cb1kenobi]

Android 6.0.1, which is the latest version I can get on my 2013 Nexus 7.

[garymathews]

@cb1kenobi Updated PR

[cb1kenobi]

Given that Android is Linux based, are you sure there's a \r character? Might be safer to do var dataStr = data.toString().trim(); and then do the endsWith().

[cb1kenobi]

output is a bad variable name since it is a function and not a buffer/string with "output".

[cb1kenobi]

That will work.