feat(all): update node dependencies #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests fail because the base64 encoded lines are in a different order 🤔 |
cb1kenobi
approved these changes
Aug 31, 2022
|
@m1ga I see I approved this PR, but never merged it!? Sigh. Since this PR is a bit old, would you mind refreshing the dependencies quick and hopefully the checks will pass? |
|
Thought I had the test order fixed but it looks like it's different again. Will check that later |
|
green again 👍 |
cb1kenobi
requested changes
Jan 12, 2023
|
Thanks for the feedback 👍 Fixed all issues |
cb1kenobi
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update some node dependencies to have a newer babel version that includes a newer browserlist/canuse-lite version.
Resolves tidev/titanium-sdk#13286
Test
/node_modules/node-titanium-sdk/folder.I'm not seeing the
npx browserslist@latest --update-dbmessage after[INFO] Processing JavaScript filesApps still build fine (Kitchensink, hyperloop examples, own app)After that we'll need to update https://github.com/tidev/titanium_mobile/blob/20d2ed1806d1cedd58f226a70b384997c5c5ac9a/package.json#L104