chore(all): update template, update tests #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
m1ga
commented
Jan 18, 2024
m1ga
commented
- remove all mobileweb, tizen, windows, blackberry parts
- move "ti.appcelerator.org" to "ti.tide.io" (it's overwriting the tisdk templates again!)
- fix tests
|
Stupid Emulator tests :-) But now it's working again |
|
This is a major breaking change. Can you bump the version in the |
cb1kenobi
requested changes
Apr 7, 2024
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "titanium", | |||
| "mobile" | |||
| ], | |||
| "version": "5.1.9", | |||
| "version": "5.2.0", | |||
There was a problem hiding this comment.
Let's do a major release.
Suggested change
| "version": "5.2.0", | |
| "version": "6.0.0", |
While you're updating the package.json, could you please set the "author": "TiDev, Inc. <npm@tidev.io>" and remove the maintainers.
We really should bump the min Node.js version to Node 16. Even then, we should drop Node 16 and 18. Ugh, maybe a larger effort. Dunno.
There was a problem hiding this comment.
sure, done 👍 I think if we do a major update we should merge #652 too so the Arm Mac users are happy again 😄
There was a problem hiding this comment.
Ok, I'll merge this and wait to publish until #652 has been reviewed/merged.
cb1kenobi
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.