Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updates): add update functionality #162

Merged
merged 8 commits into from Jun 24, 2019
Merged

Conversation

longton95
Copy link
Contributor

@longton95 longton95 commented Jun 18, 2019

Added update functionality, tried to replicate vscode #80 in atom.

Closes #157

@build
Copy link
Contributor

build commented Jun 18, 2019

Warnings
⚠️

🔍 Can't find junit reports at ./junit_report.xml, skipping generating JUnit Report.

New dependencies added: sudo-prompt and titanium-editor-commons.

sudo-prompt

Author: Joran Dirk Greef

Description: Run a command using sudo, prompting the user with an OS dialog if necessary

Homepage: https://github.com/jorangreef/sudo-prompt#readme

Createdabout 4 years ago
Last Updated21 days ago
LicenseMIT
Maintainers1
Releases44
Keywordssudo, os, dialog, prompt, command, exec, user access control, UAC, privileges, administrative, elevate and run as administrator
README

sudo-prompt

Run a non-graphical terminal command using sudo, prompting the user with a graphical OS dialog if necessary. Useful for background Node.js applications or native Electron apps that need sudo.

Cross-Platform

sudo-prompt provides a native OS dialog prompt on macOS, Linux and Windows.

macOS

Linux

Windows

Installation

sudo-prompt has no external dependencies and does not require any native bindings.

npm install sudo-prompt

Usage

Note: Your command should not start with the sudo prefix.

var sudo = require('sudo-prompt');
var options = {
  name: 'Electron',
  icns: '/Applications/Electron.app/Contents/Resources/Electron.icns', // (optional)
};
sudo.exec('echo hello', options,
  function(error, stdout, stderr) {
    if (error) throw error;
    console.log('stdout: ' + stdout);
  }
);

sudo-prompt will use process.title as options.name if options.name is not provided. options.name must be alphanumeric only (spaces are supported) and at most 70 characters.

sudo-prompt will preserve the current working directory on all platforms. Environment variables can be set explicitly using options.env.

sudo-prompt.exec() is different to child-process.exec() in that no child process is returned (due to platform and permissions constraints).

Behavior

On macOS, sudo-prompt should behave just like the sudo command in the shell. If your command does not work with the sudo command in the shell (perhaps because it uses > redirection to a restricted file), then it may not work with sudo-prompt. However, it is still possible to use sudo-prompt to get a privileged shell, see this closed issue for more information.

On Linux, sudo-prompt will use either pkexec or kdesudo to show the password prompt and run your command. Where possible, sudo-prompt will try and get these to mimic sudo. Depending on which binary is used, and due to the limitations of some binaries, the name of your program or the command itself may be displayed to your user. sudo-prompt will not use gksudo since gksudo does not support concurrent prompts. Passing options.icns is currently not supported by sudo-prompt on Linux. Patches are welcome to add support for icons based on polkit.

On Windows, sudo-prompt will elevate your command using User Account Control (UAC). Passing options.name or options.icns is currently not supported by sudo-prompt on Windows.

Non-graphical terminal commands only

Just as you should never use sudo to launch any graphical applications, you should never use sudo-prompt to launch any graphical applications. Doing so could cause files in your home directory to become owned by root. sudo-prompt is explicitly designed to launch non-graphical terminal commands. For more information, read this post.

Concurrency

On systems where the user has opted to have tty-tickets enabled (most systems), each call to exec() will result in a separate password prompt. Where tty-tickets are disabled, subsequent calls to exec() will still require a password prompt, even where the user's sudo timestamp file remains valid, due to edge cases with sudo itself, see this discussion for more information.

You should never rely on sudo-prompt to execute your calls in order. If you need to enforce ordering of calls, then you should explicitly order your calls in your application. Where your commands are short-lived, you should always queue your calls to exec() to make sure your user is not overloaded with password prompts.

Invalidating the timestamp

On macOS and Linux, you can invalidate the user's sudo timestamp file to force the prompt to appear by running the following command in your terminal:

$ sudo -k

titanium-editor-commons

Author: Axway, Inc.

Description: titanium-editor-commons in a common library for the [VS Code] and [atom] editor plugins for [Titanium SDK]. It aims to provide a common layer for the two projects.

Homepage: https://github.com/appcelerator/titanium-editor-commons#readme

Created2 months ago
Last Updatedabout 2 hours ago
LicenseApache-2.0
Maintainers1
Releases6
Direct Dependenciesappcd-subprocess, fs-extra, got, libnpm, semver and titaniumlib
README

titanium-editor-commons

titanium-editor-commons in a common library for the [VS Code] and [atom] editor plugins for [Titanium SDK]. It aims to provide a common layer for the two projects.

Generated by 🚫 dangerJS against 25a4176

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionally. Just a few comments

lib/update.js Outdated Show resolved Hide resolved
lib/update.js Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@longton95
Copy link
Contributor Author

Needs tidev/titanium-editor-commons#2 to be merged first

@tidev tidev deleted a comment from build Jun 24, 2019
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

Verified locally that unit tests pass, seems to be an environmental issue with Jenkins

Merging

@ewanharris ewanharris merged commit 57d5d1b into tidev:master Jun 24, 2019
@longton95 longton95 deleted the update branch June 24, 2019 12:37
@tidev tidev deleted a comment from build Jun 24, 2019
longton95 added a commit that referenced this pull request Jul 15, 2019
* refactor: validate enviroment components

* feat(updates): added update dialog

* chore(update): addressed build comments

* refactor(update): update env validation message

* fix(update): addressed comments

* revert(package): revert verion bump

* chore: bump commons version and changed verbiage

* chore: added updated package lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide update functionality
3 participants