New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(updates): add update functionality #162
Conversation
New dependencies added: sudo-promptAuthor: Joran Dirk Greef Description: Run a command using sudo, prompting the user with an OS dialog if necessary Homepage: https://github.com/jorangreef/sudo-prompt#readme
|
Created | 2 months ago |
Last Updated | about 2 hours ago |
License | Apache-2.0 |
Maintainers | 1 |
Releases | 6 |
Direct Dependencies | appcd-subprocess , fs-extra , got , libnpm , semver and titaniumlib |
README
titanium-editor-commons
titanium-editor-commons in a common library for the [VS Code] and [atom] editor plugins for [Titanium SDK]. It aims to provide a common layer for the two projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionally. Just a few comments
Needs tidev/titanium-editor-commons#2 to be merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
Verified locally that unit tests pass, seems to be an environmental issue with Jenkins
Merging
* refactor: validate enviroment components * feat(updates): added update dialog * chore(update): addressed build comments * refactor(update): update env validation message * fix(update): addressed comments * revert(package): revert verion bump * chore: bump commons version and changed verbiage * chore: added updated package lock
Added update functionality, tried to replicate vscode #80 in atom.
Closes #157