Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): Added support for App Open Ad type #353

Merged
merged 3 commits into from Jun 2, 2023
Merged

feat(ios): Added support for App Open Ad type #353

merged 3 commits into from Jun 2, 2023

Conversation

Astrovic
Copy link
Sponsor Contributor

@Astrovic Astrovic commented Jun 1, 2023 •
edited

v6.2.0

  • Added support for App Open Ad (https://developers.google.com/admob/ios/app-open)
  • Reset TC string if last updated date was more than 13 months ago (https://developers.google.com/admob/ios/privacy/gdpr#troubleshooting)
  • Renamed Interstitial and Rewarded Video event names:
    -- adloaded becomes didReceiveAd
    -- adfailedtoload becomes didFailToReceiveAd
    -- adrewarded becomes didRewardUser
  • Added didRecordImpression and didRecordClick events to all ad types
  • Added didFailToShowAd event to Open App ad type
  • Removed deprecated didPresentScreen event
  • Updated documentation and iOS example

ti.admob-iphone-6.2.0.zip

You can test the complete example

@Astrovic
- Added support for App Open Ad type
2a5465d 
- Events added and renamed
- Updated documentation
@Astrovic
wrong URL
a146d6b
@Astrovic Astrovic changed the title Added support for App Open Ad type [iOS] Added support for App Open Ad type Jun 2, 2023
@Astrovic Astrovic changed the title [iOS] Added support for App Open Ad type feat(ios): Added support for App Open Ad type Jun 2, 2023
hansemannn
hansemannn requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions / feedback

apidoc/Admob.yml Show resolved Hide resolved
apidoc/View.yml Outdated Show resolved Hide resolved
ios/manifest Show resolved Hide resolved
ios/documentation/index.md Show resolved Hide resolved
@hansemannn hansemannn merged commit 6df5993 into tidev:master Jun 2, 2023
1 check passed
@hansemannn
Copy link
Contributor

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Astrovic @hansemannn