Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-18916] iOS: Fix Posting a photo to Facebook #18

Merged
merged 1 commit into from
May 29, 2015
Merged

[TIMOB-18916] iOS: Fix Posting a photo to Facebook #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#### 4.0.4
- fixed photo posting for requestWithGraphPath [TIMOB-18916]
- bumped android version for parity with iOS

#### 4.0.3
- change minsdk to 4.0.0 [MOD-2119]

Expand Down
3 changes: 2 additions & 1 deletion android/documentation/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Change Log
<pre>
v4.0.4 presentWebShareDialog arguments do not work as documented [MOD-2122]
v4.0.4 presentWebShareDialog arguments do not work as documented [MOD-2122]
bumped android version for parity with iOS [TIMOB-18916]

v4.0.3 changed minsdk to 4.0.0 [mod-2119]

Expand Down
2 changes: 2 additions & 0 deletions documentation/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Change Log
<pre>
v4.0.4 fixed photo posting for requestWithGraphPath [TIMOB-18916]

v4.0.3 changed minsdk to 4.0.0 [mod-2119]

v4.0.2 Updated Facebook SDK from 3.21.1 to 3.23.1
Expand Down
8 changes: 7 additions & 1 deletion ios/Classes/FacebookModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,13 @@ -(void)requestWithGraphPath:(id)args
id args3 = [args objectAtIndex:3];
ENSURE_SINGLE_ARG(args3, KrollCallback);
KrollCallback *callback = args3;

for(NSString *key in params) {
id value = [params objectForKey:key];
if ([value isKindOfClass:[TiBlob class]]) {
TiBlob *blob = (TiBlob*)value;
[params setObject:[blob data] forKey:key];
}
}
TiThreadPerformOnMainThread(^{
FBRequestConnection *connection = [[[FBRequestConnection alloc] init] autorelease];
connection.errorBehavior = FBRequestConnectionErrorBehaviorReconnectSession
Expand Down
2 changes: 1 addition & 1 deletion ios/manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 4.0.3
version: 4.0.4
apiversion: 2
description: Allows facebook integration for Titanium apps
author: Mark Mokryn and Ng Chee Kiat
Expand Down
2 changes: 1 addition & 1 deletion ios/module.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//
// How to add a Framework (example)
FRAMEWORK_SEARCH_PATHS=$(SRCROOT)/../../modules/iphone/facebook/4.0.3/platform "~/Library/Application Support/Titanium/modules/iphone/facebook/4.0.3/platform"
FRAMEWORK_SEARCH_PATHS=$(SRCROOT)/../../modules/iphone/facebook/4.0.4/platform "~/Library/Application Support/Titanium/modules/iphone/facebook/4.0.4/platform"
OTHER_LDFLAGS=$(inherited) -framework Social -framework FacebookSDK
//
// OTHER_LDFLAGS=$(inherited) -framework Foo
Expand Down