Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-17087] Fixed bug with boolean config setting values being saved as integers. #142

Merged
merged 1 commit into from
Jun 6, 2014
Merged

[TIMOB-17087] Fixed bug with boolean config setting values being saved as integers. #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* Fixed sorting of Titanium SDKs in the 'sdk select' command to only list valid SDKs and order by their actual version number [TIMOB-16974]
* Fixed bug where integer config values were being saved as strings instead of numbers [TIMOB-17000]
* Fixed 'setup check' command when fetching available Node.js and NPM releases [TIMOB-16996]
* Fixed bug with boolean config setting values being saved as integers [TIMOB-17087]

3.2.3 (5/1/2014)
-------------------
Expand Down
2 changes: 1 addition & 1 deletion lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Object.defineProperty(config, 'set', {
value === 'null' && (value = null);
value === 'true' && (value = true);
value === 'false' && (value = false);
if (String(~~value) == value) {
if (String(~~value) === value) {
value = ~~value;
}
}
Expand Down
2 changes: 1 addition & 1 deletion locales/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,9 @@
"Exit": "Exit",
"Do you plan to build your app for Android?": "Do you plan to build your app for Android?",
"up-to-date": "up-to-date",
"bleeding edge": "bleeding edge",
"new version v%s available!": "new version v%s available!",
"(currently v%s)": "(currently v%s)",
"bleeding edge": "bleeding edge",
"new version v%s available": "new version v%s available",
"latest sdk": "latest sdk",
"unknown (offline)": "unknown (offline)",
Expand Down